feat: webapi versioning #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methods.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func (c *Client) GetApiVersion() (ApiVersion, error) { |
There was a problem hiding this comment.
This should probably be private (as well as the set). If we don't do "the right thing" it's a bug.
There was a problem hiding this comment.
vscode complained that ctx was unused (it already was before making it private) unsure if the changes I made are correct
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at tackling webapi versioning.
qBittorrent v5 (webapi 2.11) had some API endpoint renaming:
/torrents/pausewas renamed to/torrents/stop/torrents/resumewas renamed to/torrents/start