Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: firstLastPiecePrio #25

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: firstLastPiecePrio #25

merged 5 commits into from
Apr 18, 2024

Conversation

s0up4200
Copy link
Contributor

No description provided.

@s0up4200 s0up4200 mentioned this pull request Apr 17, 2024
Merged
1 task
zze0s
zze0s reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@zze0s zze0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we can set the property directly on addTorrent https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-4.1)#add-new-torrent with firstLastPiecePrio: true.

@s0up4200
Copy link
Contributor Author

Looks like we can set the property directly on addTorrent https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-4.1)#add-new-torrent with firstLastPiecePrio: true.

Can just revert a8b4232 then I guess? Still need it in domain.go right?

@zze0s
Copy link
Contributor

zze0s commented Apr 17, 2024

Looks like we can set the property directly on addTorrent https://github.com/qbittorrent/qBittorrent/wiki/WebUI-API-(qBittorrent-4.1)#add-new-torrent with firstLastPiecePrio: true.

Can just revert a8b4232 then I guess? Still need it in domain.go right?

Keep the method so others can still use it 👍

@s0up4200 s0up4200 changed the title add: ToggleFirstLastPiecePrio add: firstLastPiecePrio Apr 17, 2024
@s0up4200 s0up4200 marked this pull request as draft April 17, 2024 21:13
@s0up4200 s0up4200 marked this pull request as ready for review April 18, 2024 10:09
@s0up4200
remove from AppPreferences
0a0794a 
couldnt find info about it being present
@s0up4200
Copy link
Contributor Author

Tested locally. Property was enabled as expected in qBit 4.3.9 👍
CleanShot 2024-04-18 at 12 08 53@2x

@s0up4200 s0up4200 requested a review from zze0s April 18, 2024 10:29
@zze0s zze0s changed the title add: firstLastPiecePrio feat: firstLastPiecePrio Apr 18, 2024
zze0s
zze0s approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@zze0s zze0s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zze0s zze0s added the enhancement New feature or request label Apr 18, 2024
@zze0s zze0s merged commit 44528cc into main Apr 18, 2024
1 check passed
@zze0s zze0s deleted the feat/ToggleFirstLastPiecePrio-and-ToggleSequentialDownload branch April 18, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zze0s zze0s zze0s approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s0up4200 @zze0s