Skip to content
This repository has been archived by the owner on Feb 27, 2024. It is now read-only.

Update READMEs #18

Merged
merged 2 commits into from
Sep 25, 2023
Merged

Update READMEs #18

merged 2 commits into from
Sep 25, 2023

Conversation

nicolewhite
Copy link
Contributor

No description provided.

@@ -57,7 +57,7 @@ This project provides two actions:

**`create-branch`**:

This action creates a Neon branch for the current GitHub branch and commit. The Neon branch name will be the GitHub branch name plus the first seven characters of the commit SHA. For example, if you create a branch called `feat/my-feature` and push three commits, the following Neon branches will be created:
This action creates a Neon branch for the current GitHub branch and commit. The Neon branch name will be the GitHub branch name plus the first seven characters of the commit SHA. For example, if you create a GitHub branch called `feat/my-feature` and push three commits, the following Neon branches will be created:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would saying git branch be more correct than GitHub branch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm yeah i only added this to be clear when i'm talking about neon branches vs github branches. i think it's fine, since this is a github-specific thing and not something that would work just b/c you're using git. technically github has their own concept of a branch (on top of git branches)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@nicolewhite nicolewhite merged commit fa17947 into main Sep 25, 2023
4 checks passed
@nicolewhite nicolewhite deleted the more-readme-updates branch September 25, 2023 15:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants