Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackathon: The JAK #141

Closed
wants to merge 2 commits into from
Closed

Conversation

zfarini
Copy link
Contributor

@zfarini zfarini commented Nov 15, 2024

Description

TODO

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ zfarini
❌ Zakaria Farini


Zakaria Farini seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@zfarini zfarini closed this Nov 15, 2024
@zfarini
Copy link
Contributor Author

zfarini commented Nov 15, 2024

We created a new pull request with the same code because we had an issue with signing the license agreement

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11864681689

Details

  • 72 of 73 (98.63%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 98.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/XAD/Literals.hpp 39 40 97.5%
Files with Coverage Reduction New Missed Lines %
src/XAD/ChunkContainer.hpp 3 96.05%
Totals Coverage Status
Change from base Build 11864608732: -0.1%
Covered Lines: 2422
Relevant Lines: 2456

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants