Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove patches #514

Merged
merged 1 commit into from
May 23, 2024
Merged

Remove patches #514

merged 1 commit into from
May 23, 2024

Conversation

mtsmfm
Copy link
Contributor

@mtsmfm mtsmfm commented May 22, 2024

Currently these patches are not applied correctly since they are not compatible with current version.

https://github.com/autifyhq/autify-cli/actions/runs/9188118421/job/25267387298

**ERROR** Failed to apply patch for package @oclif/plugin-update at path
  
    node_modules/@oclif/plugin-update
**ERROR** Failed to apply patch for package oclif at path
  
    node_modules/oclif

As far as I can see, we wanted to apply these patches to:

  1. Fix update subcommand for Windows
  2. Avoid exit confirmaion for Windows

But v0.43.0 has been released without the patches 4 month ago.

I confirmed that I can use autify update on my Windows laptop, and I believe the issue 2 is not a critical issue.

So I'd like to remove these patches.

Copy link
Contributor

@4ydx 4ydx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I have no idea why we have such a big diff for just removing single package... 🤔

Copy link
Contributor Author

@mtsmfm mtsmfm May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed I can install beta build for this PR

curl https://autify-cli-assets.s3.us-west-2.amazonaws.com/autify-cli/versions/0.45.0-beta.0/73a2ef6/install-standalone.sh | sh
$ autify --version
@autifyhq/autify-cli/0.45.0-beta.0 wsl-x64 node-v18.20.1

And a command works

$ autify web api list-capabilities --project-id 1528 | jq '.[0]'
{
  "os": "Linux",
  "os_type": "linux",
  "os_version": null,
  "browser": "Chrome",
  "browser_type": "chrome",
  "browser_version": "124.0",
  "device": null,
  "device_type": "computer",
  "unsupported": false
}

@mtsmfm mtsmfm merged commit f5cbfbb into main May 23, 2024
30 checks passed
@mtsmfm mtsmfm deleted the mtsmfm/remove-patches branch May 23, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants