Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ClusterFuzzLite with go native fuzzing #830

Closed
wants to merge 2 commits into from
Closed

add ClusterFuzzLite with go native fuzzing #830

wants to merge 2 commits into from

Conversation

vroldanbet
Copy link
Contributor

@vroldanbet vroldanbet commented Sep 20, 2022 •
edited
Loading

Inspired by #709

This PR builds on top of ☝🏻 but attempts to use go native fuzzing instead.

  • initially explored oss-fuzz, but requires us to send a submission and being subject to approval
  • also tested a github action that runs go fuzz. Mostly works
  • then pivoted to ClusterFuzzLite, similar to Add ClusterfuzzLite #709, but using go native fuzzing

@github-actions github-actions bot added area/schema Affects the Schema Language area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Sep 20, 2022
@vroldanbet vroldanbet force-pushed the add-oss-fuzz branch 2 times, most recently from 5d6fbd2 to 92fede4 Compare September 20, 2022 17:16
@jzelinskie

This comment was marked as outdated.

Sign in to view
@vroldanbet vroldanbet force-pushed the add-oss-fuzz branch 2 times, most recently from 813eed5 to 098302e Compare September 20, 2022 17:45
@github-actions

This comment was marked as outdated.

Sign in to view
@vroldanbet vroldanbet mentioned this pull request Sep 21, 2022
Closed
@vroldanbet vroldanbet force-pushed the add-oss-fuzz branch 13 times, most recently from 6cd29c0 to 37126f3 Compare September 21, 2022 14:56
@vroldanbet vroldanbet changed the title adds oss-fuzz CI and a parser test add ClusterFuzzLite redux Sep 21, 2022
@vroldanbet vroldanbet changed the title add ClusterFuzzLite redux add ClusterFuzzLite with go native fuzzing Sep 21, 2022
@vroldanbet
Copy link
Contributor Author

vroldanbet commented Sep 21, 2022 •
edited
Loading

ClusterFuzzLite is running, but seems to be crashing out of memory

CFL does not run out of memory when set to 30s. However it does not identify any crash, which is surprising because go test -fuzz does 😕

@vroldanbet vroldanbet force-pushed the add-oss-fuzz branch 2 times, most recently from cdfce12 to bcbcd80 Compare September 21, 2022 16:29
@vroldanbet vroldanbet force-pushed the add-oss-fuzz branch 5 times, most recently from 70b52fe to 791d879 Compare September 21, 2022 16:49
@vroldanbet vroldanbet self-assigned this Sep 21, 2022
@vroldanbet vroldanbet force-pushed the add-oss-fuzz branch 2 times, most recently from 0e04683 to 3161262 Compare September 21, 2022 17:08
@vroldanbet
Copy link
Contributor Author

I'm going to close this one - even though fuzzing is working it does not seem to find anything:

  • running for long period of time runs out of memory
  • running for a short period of time does not find any crash. I was able to quickly find crashes with go test -fuzz locally.

@vroldanbet vroldanbet closed this Sep 21, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@vroldanbet vroldanbet

Labels
area/schema Affects the Schema Language area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vroldanbet @jzelinskie