Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PG serialization error on writes #2126

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Improve PG serialization error on writes #2126

merged 1 commit into from
Nov 8, 2024

Conversation

josephschorr
Copy link
Member

Add a nicer error message with actionable intel when a serialization error occurs during relationship writes

@josephschorr josephschorr requested a review from a team as a code owner November 8, 2024 20:38
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Nov 8, 2024
tstirrat15
tstirrat15 previously approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr
Improve PG serialization error on writes
6bbacb3 
Add a nicer error message with actionable intel when a serialization error occurs during relationship writes
tstirrat15
tstirrat15 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephschorr josephschorr added this pull request to the merge queue Nov 8, 2024
Merged via the queue into authzed:main with commit 417c9cf Nov 8, 2024
22 checks passed
@josephschorr josephschorr deleted the pg-serialization-error branch November 8, 2024 21:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
@vroldanbet
Copy link
Contributor

We should add this to CRDB as well, were we sometimes see serialization errors too

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tstirrat15 tstirrat15 tstirrat15 approved these changes

Assignees
No one assigned
Labels
area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephschorr @vroldanbet @tstirrat15