Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all and any into keywords #2105

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Conversation

tstirrat15
Copy link
Contributor

@tstirrat15 tstirrat15 commented Oct 28, 2024

Description

One of the things that we wanted to do with the new schema version. any and all should be keywords befitting their use in intersection arrow syntax, but we didn't want to break existing usages; we're making the breaking change now.

Changes

  • Add any and all to keyword list
  • Add consumeKeywords impl function to capture getting one of a set of keywords
  • Update caveat parsing code to allow for any as a keyword in type logic
  • Update test case to reflect new error messaging
  • Update lexer tests and make keyword tests exhaustive

Testing

Review. See that things are green.

@tstirrat15 tstirrat15 marked this pull request as ready for review October 28, 2024 21:32
@tstirrat15 tstirrat15 requested a review from a team as a code owner October 28, 2024 21:32
@tstirrat15 tstirrat15 force-pushed the make-all-and-any-into-keywords branch from 503d3eb to a7c8332 Compare October 28, 2024 21:43
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Oct 28, 2024
Copy link
Member

@josephschorr josephschorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tstirrat15 tstirrat15 added this pull request to the merge queue Oct 28, 2024
Merged via the queue into main with commit 45c8f10 Oct 28, 2024
22 checks passed
@tstirrat15 tstirrat15 deleted the make-all-and-any-into-keywords branch October 28, 2024 22:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants