Fix generated membership for the development package when using indir… #1399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/dispatch
josephschorr
force-pushed
the
development-membership-caveat-fix
branch
from
5760751
to
deb7938
Compare
…ect caveats Also adds a consistency test case for this scenario
josephschorr
force-pushed
the
development-membership-caveat-fix
branch
from
deb7938
to
a07ead1
Compare
ecordell
approved these changes
Jun 16, 2023
We do, but constructing it off of a schema is non-trivial and this seemed easier; I added a test to ensure Expand was returning the correct information as well. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ect caveats
Also adds a consistency test case for this scenario