grpc middleware order assertion #1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vroldanbet
changed the base branch from
main
to
decouple-middleware-modifications
github-actions
bot
added
area/CLI
vroldanbet
force-pushed
the
grpc-middleware-order-assertion
branch
2 times, most recently
from
8a89d6f
to
9d68e97
Compare
vroldanbet
force-pushed
the
grpc-middleware-order-assertion
branch
3 times, most recently
from
498f8eb
to
413a39b
Compare
vroldanbet
force-pushed
the
grpc-middleware-order-assertion
branch
from
413a39b
to
f5e6ea1
Compare
pkg/cmd/server/middleware.go
Outdated
| var none = uuid.NewString() | ||
|
|
||
| func inTest() bool { | ||
| return flag.Lookup("test.v") != nil |
There was a problem hiding this comment.
can we use the function we already have defined in the testutil package?
There was a problem hiding this comment.
I couldn't find any. Could you point me to it?
There was a problem hiding this comment.
spicedb/pkg/spiceerrors/bug.go
Line 10 in 5d33a67
There was a problem hiding this comment.
it's unexported. If you are cool with that, I can export it
vroldanbet
force-pushed
the
grpc-middleware-order-assertion
branch
from
634618d
to
035fd62
Compare
See dependency addressed in 21b87a4
vroldanbet
force-pushed
the
grpc-middleware-order-assertion
branch
from
035fd62
to
baae1a7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behaviour of gRPC streaming API middlewares can be surprising w.r.t to order of execution. This is an attempt to force the developer introducing gRPC middleware in SpiceDB to be explicit about the order.
When run in tests, the fluent API builder will wrap each middlewares into another interceptor that will run assertions on the order of execution, and panic if that expected order is not met.