Merge pull request #2118 from drigz/patch-1

Use complete sentence in error
authzed · Nov 5, 2024 · 2c3d43d · 2c3d43d
2 parents 0d5b21b + dd8a214
commit 2c3d43d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/development/validation.go b/pkg/development/validation.go
@@ -212,7 +212,7 @@ func validateSubjects(onrKey blocks.ObjectRelation, fs developmentmembership.Fou
 				log.Err(err).Msg("could not cast columnPosition to uint32")
 			}
 			failures = append(failures, &devinterface.DeveloperError{
-				Message: fmt.Sprintf("For object and permission/relation `%s`, subject `%s` found but missing from specified",
+				Message: fmt.Sprintf("For object and permission/relation `%s`, subject `%s` found but not listed in expected subjects",
 					tuple.StringONR(onr),
 					tuple.StringONR(foundSubject.Subject()),
 				),

diff --git a/pkg/development/wasm/operations_test.go b/pkg/development/wasm/operations_test.go
@@ -700,7 +700,7 @@ assertFalse: garbage
 			`assertTrue:
 - document:somedoc#view@user:jimmy`,
 			&devinterface.DeveloperError{
-				Message: "For object and permission/relation `document:somedoc#view`, subject `user:jimmy` found but missing from specified",
+				Message: "For object and permission/relation `document:somedoc#view`, subject `user:jimmy` found but not listed in expected subjects",
 				Kind:    devinterface.DeveloperError_EXTRA_RELATIONSHIP_FOUND,
 				Source:  devinterface.DeveloperError_VALIDATION_YAML,
 				Context: "document:somedoc#view",