Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add string key to materialize cursor #115

Merged
merged 1 commit into from
Aug 16, 2024
Merged

Conversation

ecordell
Copy link
Contributor

to support backends that can directly index instead of using an offset

to support backends that can directly index instead of using an offset
Copy link

@Verolop Verolop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there any scenarios where using starting_key might lead to unexpected performance/behaviour? (while still being a better option than iterating through the whole set)

@ecordell
Copy link
Contributor Author

are there any scenarios where using starting_key might lead to unexpected performance/behaviour? (while still being a better option than iterating through the whole set)

The cursor is always something that the server first sends to the client, and the client then uses for a subsequent request. It's not a client-controlled field (or if a client does modify it, we don't care about supporting the changes they make).

@ecordell ecordell merged commit 8dca579 into authzed:main Aug 16, 2024
2 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants