Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

void is not valid as a constituent in a union #1256

Closed
mfulton26 opened this issue May 21, 2024 · 1 comment
Closed

void is not valid as a constituent in a union #1256

mfulton26 opened this issue May 21, 2024 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@mfulton26
Copy link

onSigninCallback?: (user: User | void) => Promise<void> | void;

see no-invalid-void-type | typescript-eslint

I suggest using user: User | undefined or user?: User instead of user: User | void.

@pamapa pamapa added the bug Something isn't working label May 22, 2024
@pamapa pamapa added this to the 3.2.0 milestone May 22, 2024
@pamapa
Copy link
Member

pamapa commented Oct 4, 2024

fixed via 3345125

@pamapa pamapa closed this as completed Oct 4, 2024
alexandresoro pushed a commit to alexandresoro/ouca that referenced this issue Oct 7, 2024
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [react-oidc-context](https://github.com/authts/react-oidc-context) | dependencies | minor | [`3.1.1` -> `3.2.0`](https://renovatebot.com/diffs/npm/react-oidc-context/3.1.1/3.2.0) |

---

### Release Notes

<details>
<summary>authts/react-oidc-context (react-oidc-context)</summary>

### [`v3.2.0`](https://github.com/authts/react-oidc-context/releases/tag/v3.2.0)

[Compare Source](authts/react-oidc-context@v3.1.1...v3.2.0)

react-oidc-context 3.2.0 is a minor release.

No longer using `crypto-js` package, but built-in browser [crypto.subtle](https://developer.mozilla.org/en-US/docs/Web/API/Crypto/subtle) module. Crypto.subtle is available only in [secure contexts](https://developer.mozilla.org/en-US/docs/Web/Security/Secure_Contexts) (HTTPS). Also have a look into the [migration](https://github.com/authts/oidc-client-ts/blob/main/docs/migration.md) info.

#### Changelog:

-   Fixes:
    -   [#&#8203;1256](authts/react-oidc-context#1256): void is not valid as a constituent in a union
-   Features:
    -   [#&#8203;1377](authts/react-oidc-context#1377): pass signoutCallback reponse to onSignoutCallback

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4xMTAuMiIsInVwZGF0ZWRJblZlciI6IjM4LjExMC4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJkZXBlbmRlbmNpZXMiXX0=-->

Reviewed-on: https://git.tristess.app/alexandresoro/ouca/pulls/197
Reviewed-by: Alexandre Soro <[email protected]>
Co-authored-by: renovate <[email protected]>
Co-committed-by: renovate <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants