Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-925) Fix pagination for auth0_organization_member import/Create limit #964

Merged
merged 2 commits into from
May 27, 2024

Conversation

developerkunal
Copy link
Contributor

@developerkunal developerkunal commented May 27, 2024

🔧 Changes

  • Fix pagination for importing or creating auth0_organization_member to handle organizations with more than 50 members (Can't import or create auth0_organization_member on Organizations with more than 50 members #925)

    This pull request aims to enhance pagination functionality for importing or creating auth0_organization_member by addressing organizations with more than 50 members. We're transitioning from offset pagination, which has a limit of 1000 entries, to checkpoint pagination to ensure efficient retrieval of organization members beyond this limit.

    Offset pagination retrieves data by specifying the number of items to skip and the number of items to return. However, its limitation of 1000 entries can lead to inefficient data retrieval for larger datasets. Checkpoint pagination, introduced here, offers a more efficient alternative, especially when dealing with a large number of organization members.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal developerkunal requested a review from a team as a code owner May 27, 2024 09:30
@sergiught
Copy link
Contributor

Let's as well describe better what we're attempting with this PR and how it links to the eventual proper fix of swapping offset pagination with checkpoint pagination.

@developerkunal developerkunal requested a review from sergiught May 27, 2024 11:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.19%. Comparing base (525eba1) to head (45f9c41).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #964   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files         103      103           
  Lines       13886    13886           
=======================================
  Hits        12525    12525           
  Misses        968      968           
  Partials      393      393           
Files Coverage Δ
internal/auth0/organization/resource_member.go 82.25% <100.00%> (ø)

@developerkunal developerkunal merged commit db14281 into main May 27, 2024
6 checks passed
@developerkunal developerkunal deleted the fix-auth0-organization-member branch May 27, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants