Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing token_endpoint_auth_method from auth0_client example #822

Merged
merged 2 commits into from
Sep 11, 2023

Conversation

willvedd
Copy link
Contributor

@willvedd willvedd commented Sep 8, 2023

🔧 Changes

As noted in #813, the token_endpoint_auth_method was incorrectly left in an auth0_client example when it had been removed from the resource in v1.0.0-beta.1. This removal is also mentioned in the migration guide.

This PR simply removes this property from the example and thus the docs.

📚 References

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2023

Codecov Report

Merging #822 (47219be) into v1 (47219be) will not change coverage.
The diff coverage is n/a.

❗ Current head 47219be differs from pull request most recent head 6514832. Consider uploading reports for the commit 6514832 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##               v1     #822   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          99       99           
  Lines       13569    13569           
=======================================
  Hits        12197    12197           
  Misses        975      975           
  Partials      397      397           

@sergiught sergiught merged commit abd4088 into v1 Sep 11, 2023
@sergiught sergiught deleted the gh-813-token-endpoint-auth-incorrect-client-example branch September 11, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants