-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DXCDT-520: Use a custom client with retries for auth0 api client config #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## patch/fix-cert-in-test #788 +/- ##
==========================================================
+ Coverage 90.41% 90.43% +0.02%
==========================================================
Files 99 99
Lines 13122 13184 +62
==========================================================
+ Hits 11864 11923 +59
- Misses 891 893 +2
- Partials 367 368 +1
|
sergiught
force-pushed
the
fix/retry-logic
branch
from
August 24, 2023 07:29
9c2564a
to
d4bf835
Compare
sergiught
force-pushed
the
bump-go-1.21
branch
from
August 24, 2023 07:39
ba5b893
to
4c9a25e
Compare
sergiught
force-pushed
the
fix/retry-logic
branch
2 times, most recently
from
August 24, 2023 14:35
ec507a1
to
9b18a1d
Compare
willvedd
approved these changes
Aug 24, 2023
5 tasks
sergiught
force-pushed
the
fix/retry-logic
branch
from
August 25, 2023 09:07
9b18a1d
to
71389f6
Compare
sergiught
commented
Aug 25, 2023
// Cloudflare-specific server error that is generated | ||
// because Cloudflare did not receive an HTTP response | ||
// from the origin server after an HTTP Connection was made. | ||
524, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
willvedd
approved these changes
Aug 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great 👍
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
go-auth0@v1
introduced a new way of expressing retry logic when instantiating the management client. This change is a deviation from v0 which implemented unlimited retries by default. Even with three retries, users are experiencing issues #273 (comment) due to the requests running in parallel and multiple failing at the same time, quickly hitting the 3 retry count.In this PR we skip using the retry logic from the Go SDK and introduce a custom client that will:
X-RateLimit-Reset
header.📚 References
🔬 Testing
📝 Checklist