GH-660: Prevent empty mobile block on client resource #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willvedd
approved these changes
Jul 19, 2023
Widcket
reviewed
Jul 19, 2023
| Computed: true, | ||
| MaxItems: 1, | ||
| Description: "Configuration settings for Android native apps.", | ||
| AtLeastOneOf: []string{"mobile.0.ios"}, |
There was a problem hiding this comment.
Should this be "mobile.0.android"?
There was a problem hiding this comment.
No, when using AtLeastOneOf the current resource attribute is already included.
Widcket
reviewed
Jul 19, 2023
| Computed: true, | ||
| MaxItems: 1, | ||
| Description: "Configuration settings for i0S native apps.", | ||
| AtLeastOneOf: []string{"mobile.0.android"}, |
There was a problem hiding this comment.
Should this be "mobile.0.ios"?
There was a problem hiding this comment.
No, when using AtLeastOneOf the current resource attribute is already included.
sergiught
force-pushed
the
patch/client-validation
branch
from
db878d4 to
709f109
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
📚 References
Fixes: #660.
🔬 Testing
📝 Checklist