[3/X] DXCDT-461: Remove permissions field from role resource #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #714 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 85 85
Lines 13357 13357
=======================================
Hits 11689 11689
Misses 1262 1262
Partials 406 406 |
Widcket
reviewed
Jul 13, 2023
Widcket
reviewed
Jul 13, 2023
Widcket
reviewed
Jul 13, 2023
Widcket
reviewed
Jul 13, 2023
| ) diag.Diagnostics { | ||
| role, err := api.Role.Read(ctx, roleID) | ||
| if err != nil { | ||
| return diag.FromErr(err) |
There was a problem hiding this comment.
No need to handle the 404 here?
There was a problem hiding this comment.
404s need to get handled only for resources, see #604
2 tasks
Widcket
approved these changes
Jul 13, 2023
willvedd
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
Removes the deprecated permissions field from the role resource. This will only be available on the data source from now on, this is part of a push to avoid edge cases where these attributes are outdated due to the 1:1 and 1:many relationships that could perform changes on a role's permissions.
📚 References
🔬 Testing
📝 Checklist