Bump setup-go in gh actions to v4 and disable cache on release/vulncheck #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #707 +/- ##
=======================================
Coverage 87.64% 87.64%
=======================================
Files 82 82
Lines 13530 13530
=======================================
Hits 11859 11859
Misses 1263 1263
Partials 408 408 |
sergiught
changed the title
sergiught
force-pushed
the
patch/gocheck
branch
2 times, most recently
from
3da577c to
e361e8b
Compare
sergiught
commented
Jul 12, 2023
| @@ -29,3 +29,7 @@ jobs: | |||
| steps: | |||
| - name: Scan for vulnerabilities in go code | |||
| uses: golang/[email protected] | |||
| with: | |||
| go-version-input: 1.20.6 | |||
There was a problem hiding this comment.
For some reason I need to specify this to be 1.20.6, otherwise it resolve to 1.20.5 even tho we set check latest to true and cache false. 🤷🏻
Widcket
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
The v4 version of https://github.com/actions/setup-go#caching-dependency-files-and-build-output enables caching by default, however in go 1.20.5 there's a vulnerability that got fixed in 1.20.6, so we need to both make a release and check for vulnerabilities with the latest version of Go.
📚 References
🔬 Testing
📝 Checklist