Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21/X] DXCDT-441: Reintroduce support for sso integration client addon #678

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Reintroducing support for sso integration client addon on the v1 branch after correctly typing them to the new go-auth0 types.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@sergiught sergiught requested a review from a team as a code owner June 29, 2023 09:22
@codecov-commenter
Copy link

Codecov Report

Merging #678 (2efe625) into feature/DXCDT-441-client-addons-zoom-20 (b89d0e5) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           feature/DXCDT-441-client-addons-zoom-20     #678      +/-   ##
===========================================================================
+ Coverage                                    87.71%   87.75%   +0.04%     
===========================================================================
  Files                                           80       80              
  Lines                                        12896    12939      +43     
===========================================================================
+ Hits                                         11312    11355      +43     
  Misses                                        1211     1211              
  Partials                                       373      373              
Impacted Files Coverage Δ
internal/auth0/client/expand.go 94.85% <100.00%> (+0.13%) ⬆️
internal/auth0/client/flatten.go 98.01% <100.00%> (+0.06%) ⬆️
internal/auth0/client/resource.go 98.09% <100.00%> (+0.03%) ⬆️

@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-zoom-20 branch from b89d0e5 to 4bd4346 Compare June 29, 2023 15:55
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-sso-integration-21 branch from 2efe625 to 8ecb81c Compare June 29, 2023 15:57
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-zoom-20 branch from 4bd4346 to 6d3200d Compare June 29, 2023 16:06
Base automatically changed from feature/DXCDT-441-client-addons-zoom-20 to v1 June 29, 2023 16:12
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-sso-integration-21 branch from 8ecb81c to a74831b Compare June 29, 2023 16:13
@sergiught sergiught merged commit f79423e into v1 Jun 29, 2023
@sergiught sergiught deleted the feature/DXCDT-441-client-addons-sso-integration-21 branch June 29, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants