Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6/X] DXCDT-441: Reintroduce support for slack client addon #662

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

sergiught
Copy link
Contributor

🔧 Changes

Reintroducing support for slack client addon on the v1 branch after correctly typing them to the new go-auth0 types.

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@codecov-commenter
Copy link

Codecov Report

Merging #662 (d2b075b) into feature/DXCDT-441-client-addons-mscrm-5 (3bed43e) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                             @@
##           feature/DXCDT-441-client-addons-mscrm-5     #662      +/-   ##
===========================================================================
+ Coverage                                    86.89%   86.93%   +0.04%     
===========================================================================
  Files                                           80       80              
  Lines                                        12088    12128      +40     
===========================================================================
+ Hits                                         10504    10544      +40     
  Misses                                        1211     1211              
  Partials                                       373      373              
Impacted Files Coverage Δ
internal/auth0/client/expand.go 90.84% <100.00%> (+0.49%) ⬆️
internal/auth0/client/flatten.go 95.86% <100.00%> (+0.24%) ⬆️
internal/auth0/client/resource.go 97.07% <100.00%> (+0.06%) ⬆️

@sergiught sergiught marked this pull request as ready for review June 28, 2023 07:55
@sergiught sergiught requested a review from a team as a code owner June 28, 2023 07:55
Base automatically changed from feature/DXCDT-441-client-addons-mscrm-5 to v1 June 29, 2023 07:27
@sergiught sergiught force-pushed the feature/DXCDT-441-client-addons-slack-6 branch from d2b075b to 3f6bdde Compare June 29, 2023 07:28
@sergiught sergiught merged commit f3719fa into v1 Jun 29, 2023
@sergiught sergiught deleted the feature/DXCDT-441-client-addons-slack-6 branch June 29, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants