This repository has been archived by the owner on Jun 23, 2023. It is now read-only.
fix missing zip package in dockerfile #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radekk
previously approved these changes
Mar 5, 2020
|
@eliottthomas1 one more thing, would it be possible to GPG sign this commit? otherwise I can't merge it since we blocked merging non-signed commits and it's enforced on the repository level. You can rebase your branch to sign already commited changes and push force that. References: |
|
@radekk yep sure will sign and recommit |
eliottthomas1
force-pushed
the
fix-missing-zip-package-in-dockerfile
branch
from
5780704 to
f3ced12
Compare
|
Perfect! Thanks, it looks good now. Let me merge that. |
radekk
approved these changes
Mar 5, 2020
radekk
pushed a commit
that referenced
this pull request
Mar 5, 2020
|
I just fixed the latest commit in the master branch. I merged this PR using squash method and it didn't authored this commit with your details which I didn't like. I don't want to get credits for your work. It seems to be an issue how github handles that: isaacs/github#1368 (comment) It should be good right now and you're listed as a contributor 👍 |
eliottthomas1
pushed a commit
to eliottthomas1/repo-supervisor
that referenced
this pull request
Mar 10, 2020
eliottthomas1
pushed a commit
to eliottthomas1/repo-supervisor
that referenced
this pull request
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.
Description
Fix for missing Zip package in Dockerfile.
Docker image successfully builds with this package included.
References
#41
Testing
Build the docker image with the version 3.0.0 changes and include the Zip package as i have done.
Checklist
master