Inline templates

[chris-armstrong]

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

The purpose of this PR is to make it easier to use xml-encryption with a bundler, like webpack.

This PR inlines the template files used by utils.js as JavaScript files instead of using fs.readFileSync() to load them.

This allows webpack to statically include the templates, instead of depending on hacks like that described in #55.

References

See #55

Testing

This code adds no new functionality. Tests pass locally.

Checklist

• I have added documentation for new/changed functionality in this PR or in auth0.com/docs
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not master

[chris-armstrong]

Please note the node 4 and 6 builds are failing because of the include mocha upgrade - both these versions of node have long since been deprecated, and the mocha upgrade was necessary to get rid of known security issues in mocha 3.3.0 dependencies.

[gkwang]

@chris-armstrong thanks for the PR. Can you remove node 4 and 6 from the travis config file so that the CI build will go through?
We will be cutting a new major soon along with this change.
Thanks!

[gkwang]

Thanks @chris-armstrong looks good. One last ask, can you have the commits signed? We require signed commits to be able to merge into master.
You can follow the process here: https://help.github.com/en/github/authenticating-to-github/managing-commit-signature-verification.

[chris-armstrong]

This will take some more time - I'll look into it

…

On Thu, Jan 16, 2020, at 11:39 AM, George wrote: Thanks @chris-armstrong <https://github.com/chris-armstrong> looks good. One last ask, can you have the commits signed? We require signed commits to be able to merge into master. You can follow the process here: https://help.github.com/en/github/authenticating-to-github/managing-commit-signature-verification. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#59?email_source=notifications&email_token=ACXLO5ZNDGJKE44IRHMHO4DQ56UD7A5CNFSM4KF4X432YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEJCKNKQ#issuecomment-574924458>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACXLO5ZRSLAOLZVHWF2I2V3Q56UD7ANCNFSM4KF4X43Q>.

-- Christopher Armstrong [email protected]

[chris-armstrong]

Commits are verified now.