Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pending Review] Release 2.0.1 #101

Closed
wants to merge 1 commit into from
Closed

[Pending Review] Release 2.0.1 #101

wants to merge 1 commit into from

Conversation

gkwang
Copy link
Contributor

@gkwang gkwang commented Oct 13, 2022

Add semgrep support
Update xmldom

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

Describe the purpose of this PR along with any background information and the impacts of the proposed change. For the benefit of the community, please do not assume prior context.

Provide details that support your chosen implementation, including: breaking changes, alternatives considered, changes to the API, etc.

If the UI is being changed, please provide screenshots.

References

Include any links supporting this change such as a:

  • GitHub Issue/PR number addressed or fixed
  • Auth0 Community post
  • StackOverflow post
  • Support forum thread
  • Related pull requests/issues from other repos

If there are no references, simply delete this section.

Testing

Describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors.

Please include any manual steps for testing end-to-end or functionality not covered by unit/integration tests.

Also include details of the environment this PR was developed in (language/platform/browser version).

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

Add semgrep support
Update xmldom
@gkwang gkwang requested a review from a team as a code owner October 13, 2022 15:48
@gkwang gkwang changed the title Release 2.0.1 [Pending Review] Release 2.0.1 Oct 13, 2022
@gkwang gkwang requested a review from esarafianou October 14, 2022 22:57
mcab added a commit to Clever/saml2 that referenced this pull request Oct 15, 2022
For [0].

Any usage of @xmldom/xmldom >= 0.8.0 will normalize these. See [1] and [2].

The current xml-encryption (2.0.0) does not do this normalization, but will
in 2.0.1 [3]. It's technically within the path of xmlenc.decrypt() [4], but
this follows how assertions have been handled (not handling non-normalized
whitespace).

[0] https://github.com/Clever/saml2/blob/6da3e9c39c326a2f6793bb87c6d12c9ab4446585/lib/saml2.coffee#L242-L245
[1] xmldom/xmldom#307
[2] xmldom/xmldom#314
[3] auth0/node-xml-encryption#101
[4] https://github.com/auth0/node-xml-encryption/blob/291f3f10d5d1d571a3b6da2d411aa323398f5650/lib/xmlenc.js#L185
mcab added a commit to Clever/saml2 that referenced this pull request Oct 15, 2022
For [0].

Any usage of @xmldom/xmldom >= 0.8.0 will normalize these, see [1] and [2].

The current xml-encryption (2.0.0) does not do this normalization, but will
in 2.0.1 [3]. It's technically within the path of xmlenc.decrypt() [4], but
this follows how assertions have been handled (not handling non-normalized
whitespace).

For xml-crypto, this was changed in 3.0.0 with [5].

[0] https://github.com/Clever/saml2/blob/6da3e9c39c326a2f6793bb87c6d12c9ab4446585/lib/saml2.coffee#L242-L245
[1] xmldom/xmldom#307
[2] xmldom/xmldom#314
[3] auth0/node-xml-encryption#101
[4] https://github.com/auth0/node-xml-encryption/blob/291f3f10d5d1d571a3b6da2d411aa323398f5650/lib/xmlenc.js#L185
[5] node-saml/xml-crypto#261
mcab added a commit to Clever/saml2 that referenced this pull request Oct 15, 2022
For [0].

Any usage of @xmldom/xmldom >= 0.8.0 will normalize these, see [1] and [2].

The current xml-encryption (2.0.0) does not do this normalization, but will
in 2.0.1 [3]. It's technically within the path of xmlenc.decrypt() [4], but
this follows how assertions have been handled (not handling non-normalized
whitespace).

For xml-crypto, this was changed in 3.0.0 with [5].

[0] https://github.com/Clever/saml2/blob/6da3e9c39c326a2f6793bb87c6d12c9ab4446585/lib/saml2.coffee#L242-L245
[1] xmldom/xmldom#307
[2] xmldom/xmldom#314
[3] auth0/node-xml-encryption#101
[4] https://github.com/auth0/node-xml-encryption/blob/291f3f10d5d1d571a3b6da2d411aa323398f5650/lib/xmlenc.js#L185
[5] node-saml/xml-crypto#261
mcab added a commit to Clever/saml2 that referenced this pull request Oct 15, 2022
For [0].

Any usage of @xmldom/xmldom >= 0.8.0 will normalize these, see [1] and [2].

The current xml-encryption (2.0.0) does not do this normalization, but will
in 2.0.1 [3]. It's technically within the path of xmlenc.decrypt() [4], but
this follows how assertions have been handled (not handling non-normalized
whitespace).

For xml-crypto, this was changed in 3.0.0 with [5].

[0] https://github.com/Clever/saml2/blob/6da3e9c39c326a2f6793bb87c6d12c9ab4446585/lib/saml2.coffee#L242-L245
[1] xmldom/xmldom#307
[2] xmldom/xmldom#314
[3] auth0/node-xml-encryption#101
[4] https://github.com/auth0/node-xml-encryption/blob/291f3f10d5d1d571a3b6da2d411aa323398f5650/lib/xmlenc.js#L185
[5] node-saml/xml-crypto#261
@gkwang
Copy link
Contributor Author

gkwang commented Oct 18, 2022

closing in favor of #104

@gkwang gkwang closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant