feat(xml/sign): unsigned assertions should have whitespace removed as…

… well
auth0 · Sep 14, 2020 · 968d0e7 · 968d0e7
1 parent b48516a
commit 968d0e7
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/xml/sign.js b/lib/xml/sign.js
@@ -39,7 +39,7 @@ exports.fromSignXmlOptions = function (options) {
    * @return {string}
    */
   return function signXmlDocument(doc, callback) {
-    var token = utils.removeWhitespace(doc.toString());
+    var unsigned = exports.unsigned(doc);
     var cert = utils.pemToCert(pem);
 
     var sig = new SignedXml(null, { signatureAlgorithm: algorithms.signature[signatureAlgorithm], idAttribute: idAttribute });
@@ -56,7 +56,7 @@ exports.fromSignXmlOptions = function (options) {
       }
     };
 
-    sig.computeSignature(token, {
+    sig.computeSignature(unsigned, {
       location: { reference: xpathToNodeBeforeSignature, action: 'after' },
       prefix: signatureNamespacePrefix
     });
@@ -76,7 +76,7 @@ exports.fromSignXmlOptions = function (options) {
  * @return {string}
  */
 exports.unsigned = function (doc, callback) {
-  var xml = doc.toString();
+  var xml = utils.removeWhitespace(doc.toString());
   if (callback) {
     setImmediate(callback, null, xml)
   } else {