Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types should not be dependencies #425

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andreujuanc
Copy link

By submitting a PR to this repository, you agree to the terms within the Auth0 Code of Conduct. Please see the contributing guidelines for how to create and submit a high-quality PR for this repo.

Description

moved the types from dependencies, to devdependencies.

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not the default branch

@andreujuanc andreujuanc requested a review from a team as a code owner October 2, 2024 23:58
@andreujuanc
Copy link
Author

Found this who added it #314

@andreujuanc
Copy link
Author

First time was added 6fc054d
PR: #9
Real bad excuse to have it moved. Consumers of this library SHOULD NOT compile it, but instead, it should come pre-bundled.

@andreujuanc
Copy link
Author

BTW if the problem is that this library is exposing dependencies' types, those can be added as peerDependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant