Fix types in client-side withPageAuthRequired

[slaypni]

Description

This PR modifies types related to client-side withPageAuthRequired to fix several issues.

• Return type of withPageAuthRequired has user in props incorrectly
• Passing { user: UserProfile } as a part of generic parameter of withPageAuthRequired seems redundant
• Props of component passed to withPageAuthRequired does not infer types properly

These issues are commented in a sample code below:

export async function getStaticProps() {
  return {
    props: {
      locale: "en"
    }
  };
}

// passing `{ user: UserProfile }` as a part of generic parameter for `withPageAuthRequired` is necessary, that seems redundant.
const Page = withPageAuthRequired<InferGetStaticPropsType<typeof getStaticProps> & { user: UserProfile }>(
  ({ locale, user }) => {    
    // `locale` and `user` are inferred `any` here. they should be `string` and `UserProfile`.
    return <></>;
  }
);
// type of `Page` is `FC<{ locale: string; } & { user: UserProfile; }>`, where `{ user: UserProfile }` is improper.
export default Page

Solutions

• Take { user: UserProfile } apart from WithPageAuthRequiredProps
• Swap call signatures in WithPageAuthRequired for the last issue
  • Although I am not sure the cause of the improper type inference

Testing

If this PR solves those issues can be checked by following code:

export async function getStaticProps() {
  return {
    props: {
      locale: "en"
    }
  };
}

// `{ user: UserProfile }` can be omitted from generic parameter
const Page = withPageAuthRequired<InferGetStaticPropsType<typeof getStaticProps>>(
  // type of `locale` is `string` and `user` is `UserProfile`
  ({ locale, user }) => {    
    return <></>;
  }
);
// type of `Page` is `FC<{ locale: string; }>`
export default Page

TypeScript 4.5.4 is used for my check

• This change adds test coverage for new/changed/fixed functionality

Checklist

• I have added documentation for new/changed functionality in this PR or in auth0.com/docs
• All active GitHub checks for tests, formatting, and security are passing
• The correct base branch is being used, if not main

[vercel]

@slaypni is attempting to deploy a commit to the Auth0 Team on Vercel.

A member of the Team first needs to authorize it.

[adamjmcgrath]

lgtm - thanks @slaypni