Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-2259] Remove env var dependency at build time #255

Merged
merged 3 commits into from
Jan 25, 2021

Conversation

adamjmcgrath
Copy link
Contributor

@adamjmcgrath adamjmcgrath commented Jan 25, 2021

Description

Because of static generation withPageAuthRequired is called at build time. We need to move the dependency withPageAuthRequired has on the server instance to be at runtime, so that you don't need to specify environment variables to configure the SDK at build time

References

fixes: #154

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have added documentation for new/changed functionality in this PR or in auth0.com/docs
  • All active GitHub checks for tests, formatting, and security are passing
  • The correct base branch is being used, if not master

@adamjmcgrath adamjmcgrath added the review:small Small review label Jan 25, 2021
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner January 25, 2021 15:18
@vercel
Copy link

vercel bot commented Jan 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/auth0/nextjs-auth0/ocmmjleie
✅ Preview: https://nextjs-auth0-git-lazy-runtime-anv.auth0.vercel.app

@StianOvrevage
Copy link

Is there a chance of getting this merged into main branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants