-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for passing a custom http agent #1447
Add support for passing a custom http agent #1447
Conversation
@ryanolson-aumni is attempting to deploy a commit to the Auth0 Team on Vercel. A member of the Team first needs to authorize it. |
@adamjmcgrath is this more in line with what you were thinking? |
a6b38bf
to
0024ac6
Compare
@ryanolson-aumni 👋 Adam is on holiday this week, but he'll get back to you when he returns |
There are times that you'd need to have a custom http agent for making the authentication requests (via openid-client). This can allow a user to provide their own agent so that they can proxy or do other things that they'd like to do. Resolves auth0#1425
0024ac6
to
223af62
Compare
These lgtm - thanks @ryanolson-aumni You just need to add Also, could you add a note to the docstrings explaining that this option is for the Node runtime only. |
Thanks @adamjmcgrath. I added commits that address your feedback. 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ryanolson-aumni!
There are times that you'd need to have a custom http agent for making the authentication requests (via openid-client). This can allow a user to provide their own agent so that they can proxy or do other things that they'd like to do.
📋 Changes
httpAgent
so that users can provide their own http agent for authentication requests (such as an HttpsProxyAgent). This is important for corporate users that require going through a corporate proxy.