Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where storeIDToken config not used by getAccessToken #1091

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

adamjmcgrath
Copy link
Contributor

📋 Changes

Fix an issue where storeIDToken config was not honoured by the new session from refreshing an access token.

📎 References

See #1085 (comment)

🎯 Testing

// AUTH0_SESSION_STORE_ID_TOKEN=false
const oldSession = await getSession(ctx.req, ctx.res);
assertEqual(oldSession.idToken, undefined);
const accessToken = await getAccessToken(ctx.req, ctx.res, { refresh: true });
const newSession = await getSession(ctx.req, ctx.res);
assertEqual(newSession.idToken, undefined); 💥 

@adamjmcgrath adamjmcgrath added the review:small Small review label Mar 1, 2023
@adamjmcgrath adamjmcgrath requested a review from a team as a code owner March 1, 2023 17:32
@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nextjs-auth0 ⬜️ Ignored (Inspect) Mar 1, 2023 at 5:32PM (UTC)

@adamjmcgrath adamjmcgrath merged commit 175b9e0 into main Mar 2, 2023
@adamjmcgrath adamjmcgrath deleted the fix-store-id-token-config branch March 2, 2023 10:44
@adamjmcgrath adamjmcgrath mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review:small Small review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants