fix: Correct syntax error in Auth Guard for substantial performance gains #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for substantial performance gains Signed-off-by: Russ <[email protected]>
evansims
added
Scope: Bug
|
Sorry. Fix needs fixing. Let me see if I can noodle it out... |
|
No worries, @ComputerTinker; I appreciate you putting the efforts forward there. Let me know if you need any support in figuring things out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Current code is finding session, setting credential and pushing state with every call to getCredential(). Fix replaces missing NOT operator so code correctly uses cached credential if available.
Testing
We have several pages in our app which return collections of tens of thousands of Eloquent records. After installing laravel-auth0 we noticed the performance of these pages degrade by 2x-6x depending on the records involved, sometimes resulting in timeout errors. With the fix in place, performance has returned to normal.
Contributor Checklist