Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add additional Telescope state check #447

Conversation

samuelhgf
Copy link
Contributor

Changes

  • Add one more verification of existence of Telescope on the project. Letting be disabled trough env var when running tests.
  • Change use o Telescope class to CONST

References

Testing

Contributor Checklist

@samuelhgf
Copy link
Contributor Author

@evansims I later saw this other place with the infinite loop workarorund.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.69%. Comparing base (9ff4aa7) to head (29c710a).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #447   +/-   ##
=========================================
  Coverage     99.69%   99.69%           
- Complexity      535      536    +1     
=========================================
  Files            31       31           
  Lines          1332     1332           
=========================================
  Hits           1328     1328           
  Misses            4        4           
Flag Coverage Δ
unittestsvalidate 99.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@evansims evansims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @samuelhgf

@evansims evansims merged commit 842946a into auth0:main Mar 15, 2024
25 checks passed
@evansims evansims changed the title Add verification if telescope is enabled using config helper in other place refactor: add additional Telescope state check Mar 15, 2024
@evansims evansims mentioned this pull request Apr 1, 2024
@samuelhgf samuelhgf deleted the refactor/add-telescope-enabled-config-verification branch June 25, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants