feature: Auth middleware will now setIntendedUrl() before login redirect #364
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR updates the
Auth0\Laravel\Http\Middleware\Stateful\Authenticate
route middleware tosetIntendedUrl()
from an intercepted request before issuing the redirect to the login route.The callback route was already configured to issue redirects after login that default to honouring any assigned intended URLs, so no other changes are necessary elsewhere.
To illustrate this process:
/protected-route
.auth0.authorize
middleware determines visitor is not authenticated.auth0.authorize
makes note that the visitor was trying to access/protected-route
.auth0.authorize
redirects to/login
to kick off the authentication flow./callback
.Auth0\Laravel\Http\Controller\Stateful
(the/callback
controller) completes the code exchange, and validates the session.Auth0\Laravel\Http\Controller\Stateful
issues aredirect()->intended(...)
, which picks up the intended URL thatauth0.authorize
noted earlier./protected-route
, now with an authenticated session.References
Resolves #357
Testing
Tests have been updated to cover this new feature.
Contributor Checklist