Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3791] add: Raise additional Laravel Auth Events #331

Merged
merged 2 commits into from
Nov 7, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented Nov 7, 2022

Changes

This PR includes enhancements requested by nickescobedo in #328 to raise additional Laravel authentication events. This should improve interoperability with other Laravel packages that interact with the authentication layer.

I've added the following Laravel auth events:

  • Illuminate\Auth\Events\Attempting
  • Illuminate\Auth\Events\Validated
  • Illuminate\Auth\Events\Failed
  • Illuminate\Auth\Events\Login
  • Illuminate\Auth\Events\Authenticated
  • Illuminate\Auth\Events\Logout

I've also added a few new SDK events for stateless token verification events:

  • Auth0\Laravel\Event\Stateless\TokenVerificationAttempting
  • Auth0\Laravel\Event\Stateless\TokenVerificationFailed
  • Auth0\Laravel\Event\Stateless\TokenVerificationSucceeded

References

Resolves #328

Testing

Run composer test from a locally cloned repo, or review the GitHub status checks below.

Contributor Checklist

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@evansims evansims linked an issue Nov 7, 2022 that may be closed by this pull request
@evansims evansims marked this pull request as ready for review November 7, 2022 19:54
@evansims evansims requested a review from a team as a code owner November 7, 2022 19:54
@evansims evansims modified the milestones: 7.4.0, 7.3.0 Nov 7, 2022
@evansims evansims changed the title change: Raise additional Laravel Auth Events added: Raise additional Laravel Auth Events Nov 7, 2022
@evansims evansims changed the title added: Raise additional Laravel Auth Events add: Raise additional Laravel Auth Events Nov 7, 2022
@evansims evansims merged commit 30a724e into main Nov 7, 2022
@evansims evansims deleted the 328-laravel-loginlogout-event-not-dispatched branch November 7, 2022 21:29
@evansims evansims mentioned this pull request Nov 7, 2022
@evansims evansims changed the title add: Raise additional Laravel Auth Events [SDK-3791] add: Raise additional Laravel Auth Events Nov 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Laravel Login/Logout Event Not Dispatched
2 participants