Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK-3721] Bump minimum auth0/auth0-php version to ^8.3.4 #322

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

evansims
Copy link
Member

@evansims evansims commented Oct 19, 2022

Changes

This PR bumps the minimum supported auth0/auth0-php dependency version installed from ^8.0 to ^8.3.4, which includes some important fixes specifically for the Laravel package under PHP 8.0+.

References

See internal ticket SDK-3721.

Testing

Please see GitHub status checks, or run composer test from a local clone of the project directory.

Contributor Checklist

@evansims evansims added this to the 7.2.3 milestone Oct 19, 2022
@evansims evansims marked this pull request as ready for review October 19, 2022 03:23
@evansims evansims requested a review from a team as a code owner October 19, 2022 03:23
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Base: 9.50% // Head: 9.50% // No change to project coverage 👍

Coverage data is based on head (ada7aa5) compared to base (e3b5417).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              main    #322   +/-   ##
=======================================
  Coverage     9.50%   9.50%           
  Complexity     202     202           
=======================================
  Files           23      23           
  Lines          547     547           
=======================================
  Hits            52      52           
  Misses         495     495           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Viliasas
Copy link

"auth0/login" 7.2.1 package has issues with "auth0/auth0-php" 8.3.2 package, when used with API strategy.

First issue is due to "cookiePath" path setting defaulting to null, when "auth0/auth0-php" requires a string. Maybe a solution would be to alter published auth0 config to include default value 'cookiePath' => env('AUTH0_COOKIE_PATH', '/'),.

TypeError: Auth0\SDK\Configuration\SdkConfiguration::setCookiePath(): Argument #1 ($cookiePath) must be of type string, null given, called in C:\project\vendor\auth0\auth0-php\src\Mixins\ConfigurableMixin.php on line 29 and defined in C:\project\vendor\auth0\auth0-php\src\Configuration\SdkConfiguration.php:224
Stack trace:
#0 C:\project\vendor\auth0\auth0-php\src\Mixins\ConfigurableMixin.php(29): Auth0\SDK\Configuration\SdkConfiguration->setCookiePath(NULL)
#1 [internal function]: Auth0\SDK\Configuration\SdkConfiguration->Auth0\SDK\Mixins\{closure}(NULL)
#2 C:\project\vendor\auth0\auth0-php\src\Mixins\ConfigurableMixin.php(32): call_user_func(Object(Closure), NULL)
#3 C:\project\vendor\auth0\auth0-php\src\Configuration\SdkConfiguration.php(138): Auth0\SDK\Configuration\SdkConfiguration->applyConfigurationState(Array)
#4 C:\project\vendor\auth0\login\src\Auth0.php(80): Auth0\SDK\Configuration\SdkConfiguration->__construct(Array)
#5 C:\project\vendor\auth0\login\src\Auth0.php(38): Auth0\Laravel\Auth0->getConfiguration()
#6 C:\project\vendor\laravel\framework\src\Illuminate\Support\Facades\Facade.php(338): Auth0\Laravel\Auth0->getSdk()
#7 C:\project\app\Auth\CustomAuth0Guard.php(62): Illuminate\Support\Facades\Facade::__callStatic('getSdk', Array)
#8 C:\project\vendor\laravel\framework\src\Illuminate\Auth\AuthManager.php(336): App\Auth\CustomAuth0Guard->user()
#9 C:\project\vendor\laravel\framework\src\Illuminate\Support\Facades\Facade.php(338): Illuminate\Auth\AuthManager->__call('user', Array)
#10 C:\project\app\Logging\Processors\GelfCustomProcessor.php(14): Illuminate\Support\Facades\Facade::__callStatic('user', Array)
#11 C:\project\vendor\monolog\monolog\src\Monolog\Handler\ProcessableHandlerTrait.php(63): App\Logging\Processors\GelfCustomProcessor->__invoke(Array)
#12 C:\project\vendor\monolog\monolog\src\Monolog\Handler\AbstractProcessingHandler.php(43): Monolog\Handler\AbstractProcessingHandler->processRecord(Array)
#13 C:\project\vendor\monolog\monolog\src\Monolog\Logger.php(379): Monolog\Handler\AbstractProcessingHandler->handle(Array)
#14 C:\project\vendor\monolog\monolog\src\Monolog\Logger.php(587): Monolog\Logger->addRecord(200, 'Request started...', Array)
#15 C:\project\vendor\laravel\framework\src\Illuminate\Log\Logger.php(183): Monolog\Logger->info('Request started...', Array)
#16 C:\project\vendor\laravel\framework\src\Illuminate\Log\Logger.php(130): Illuminate\Log\Logger->writeLog('info', 'Request started...', Array)
#17 C:\project\vendor\laravel\framework\src\Illuminate\Log\LogManager.php(683): Illuminate\Log\Logger->info('Request started...', Array)
#18 C:\project\vendor\laravel\framework\src\Illuminate\Support\Facades\Facade.php(338): Illuminate\Log\LogManager->info('Request started...')
#19 C:\project\app\Http\Middleware\BeforeMiddleware.php(20): Illuminate\Support\Facades\Facade::__callStatic('info', Array)
#20 C:\project\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): App\Http\Middleware\BeforeMiddleware->handle(Object(Illuminate\Http\Request), Object(Closure))
#21 C:\project\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#22 C:\project\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(165): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#23 C:\project\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(134): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#24 C:\project\public\index.php(52): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#25 {main}

When this value is provided then there is a different exception:

TypeError: Auth0\SDK\Utility\TransientStoreHandler::__construct(): Argument #1 ($store) must be of type Auth0\SDK\Contract\StoreInterface, null given, called in C:\project\vendor\auth0\auth0-php\src\Auth0.php on line 607 and defined in C:\project\vendor\auth0\auth0-php\src\Utility\TransientStoreHandler.php:24
Stack trace:
#0 C:\project\vendor\auth0\auth0-php\src\Auth0.php(607): Auth0\SDK\Utility\TransientStoreHandler->__construct(NULL)
#1 C:\project\vendor\auth0\auth0-php\src\Auth0.php(198): Auth0\SDK\Auth0->getTransientStore()
#2 C:\project\app\Auth\CustomAuth0Guard.php(78): Auth0\SDK\Auth0->decode('...', NULL, NULL, NULL, NULL, NULL, NULL, 2)
#3 C:\project\vendor\laravel\framework\src\Illuminate\Auth\AuthManager.php(336): App\Auth\CustomAuth0Guard->user()
#4 C:\project\vendor\laravel\framework\src\Illuminate\Support\Facades\Facade.php(338): Illuminate\Auth\AuthManager->__call('user', Array)
#5 C:\project\app\Logging\Processors\GelfCustomProcessor.php(14): Illuminate\Support\Facades\Facade::__callStatic('user', Array)
#6 C:\project\vendor\monolog\monolog\src\Monolog\Handler\ProcessableHandlerTrait.php(63): App\Logging\Processors\GelfCustomProcessor->__invoke(Array)
#7 C:\project\vendor\monolog\monolog\src\Monolog\Handler\AbstractProcessingHandler.php(43): Monolog\Handler\AbstractProcessingHandler->processRecord(Array)
#8 C:\project\vendor\monolog\monolog\src\Monolog\Logger.php(379): Monolog\Handler\AbstractProcessingHandler->handle(Array)
#9 C:\project\vendor\monolog\monolog\src\Monolog\Logger.php(587): Monolog\Logger->addRecord(200, 'Request started...', Array)
#10 C:\project\vendor\laravel\framework\src\Illuminate\Log\Logger.php(183): Monolog\Logger->info('Request started...', Array)
#11 C:\project\vendor\laravel\framework\src\Illuminate\Log\Logger.php(130): Illuminate\Log\Logger->writeLog('info', 'Request started...', Array)
#12 C:\project\vendor\laravel\framework\src\Illuminate\Log\LogManager.php(683): Illuminate\Log\Logger->info('Request started...', Array)
#13 C:\project\vendor\laravel\framework\src\Illuminate\Support\Facades\Facade.php(338): Illuminate\Log\LogManager->info('Request started...')
#14 C:\project\app\Http\Middleware\BeforeMiddleware.php(20): Illuminate\Support\Facades\Facade::__callStatic('info', Array)
#15 C:\project\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(180): App\Http\Middleware\BeforeMiddleware->handle(Object(Illuminate\Http\Request), Object(Closure))
#16 C:\project\vendor\laravel\framework\src\Illuminate\Pipeline\Pipeline.php(116): Illuminate\Pipeline\Pipeline->Illuminate\Pipeline\{closure}(Object(Illuminate\Http\Request))
#17 C:\project\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(165): Illuminate\Pipeline\Pipeline->then(Object(Closure))
#18 C:\project\vendor\laravel\framework\src\Illuminate\Foundation\Http\Kernel.php(134): Illuminate\Foundation\Http\Kernel->sendRequestThroughRouter(Object(Illuminate\Http\Request))
#19 C:\project\public\index.php(52): Illuminate\Foundation\Http\Kernel->handle(Object(Illuminate\Http\Request))
#20 {main}

@evansims
Copy link
Member Author

Hey @Viliasas 👋 Thanks for letting me know! I have some fixes being prepped over on the auth0/auth0-php side for those issues.

@Widcket Widcket merged commit add088c into main Oct 19, 2022
@Widcket Widcket deleted the fix/pin-auth0-php-dependency branch October 19, 2022 15:41
@evansims evansims changed the title [SDK-3721] Bump minimum auth0/auth0-php version to ^8.3.2 [SDK-3721] Bump minimum auth0/auth0-php version to ^8.3.4 Oct 20, 2022
@evansims evansims mentioned this pull request Oct 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants