fix: CacheBridgeAbstract::save() not assigning value to cache when …

…cache hit mises (#434) * Fixed item cache value Signed-off-by: Sergey Mutaf <[email protected]> * Update tests for successful passing --------- Signed-off-by: Sergey Mutaf <[email protected]> Co-authored-by: Evan Sims <[email protected]> Co-authored-by: Evan Sims <[email protected]>
auth0 · Dec 7, 2023 · 30aafed · 30aafed
1 parent a53f05c
commit 30aafed
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/src/Bridges/CacheBridgeAbstract.php b/src/Bridges/CacheBridgeAbstract.php
@@ -118,7 +118,7 @@ final public function save(CacheItemInterface $item): bool
             return false;
         }
 
-        $value = serialize($item->get());
+        $value = serialize($item->getRawValue());
         $key = $item->getKey();
         $expires = $item->getExpiration();
 

diff --git a/tests/Unit/Bridges/CacheBridgeTest.php b/tests/Unit/Bridges/CacheBridgeTest.php
@@ -36,22 +36,20 @@
     expect($cache)
         ->toBeInstanceOf(CacheItemBridge::class)
         ->isHit()->toBeTrue()
-        ->get()->toBeNull()
-        ->set(42)
-        ->get()->toBe(42);
+        ->get()->toEqual(42);
 
     $results = $pool->getItems();
 
     expect($results)
         ->toBeArray()
         ->toHaveCount(0);
 
-    $results = $pool->getItems(['testing' => uniqid()]);
+    $results = $pool->getItems(['testing']);
 
     expect($results['testing'])
         ->toBeInstanceOf(CacheItemBridge::class)
         ->isHit()->toBeTrue()
-        ->get()->not()->toBe(42);
+        ->get()->toEqual(42);
 
     $this->app[\Illuminate\Cache\CacheManager::class]
         ->getStore()