-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raise minimum Node.js version to 18 #209
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, i was about to do that but you beat me to it 🎉😀
@frederikprijck I think you'll have to remove the Node 16 status check from the required checks in the GitHub settings, otherwise this PR will not pass the status checks. |
Yes will look at getting the pr's merged tomorrow. |
Is this done just to reduce the burden on the team needing to support this (e.g. the test suite failures), or is there an actual known incompatability with node v16 that is inspiring this? I have a dependency that relies on |
@tsheaff This was done because node 16 is no longer supported from the node side, and we do not support unsupported platforms or runtimes where possible as that has potential security risk and is something you want to avoid. That said, node 16 should support atob, so you might be good. But we do not have support for that, so usage is at your own risk. If you want to be sure, clone our repository and run our test suite against node 16, but realy, you want to update node to 18 at least. Additionally, u can also stick to using v3 until you are on node 18. Both v3 and v4 are considered rather stable and dependency-less and the code base is pretty identical if you ignore the polyfil we ship in v3. |
Raises the minimum Node.js version to 18, as version 16 will be end-of-life on September 11th. See the Node.js release schedule for more information.