Optional support for connection / read timeout

[skjolber]

This would be really helpful for minimizing the impact of some transient network issues we are experiencing in our legacy network.

[skjolber]

@lbalmaceda would you prefer validation of the connect-/read-timeout in the constructor? Any value below 0 will throw IllegalArgumentException in URLConnection.

[lbalmaceda]

Thanks for the contribution.

Regarding defaults: Why not just use an Integer and check for null? null would mean "use the default" or "don't overwrite it at all".

Regarding validation: Yes, I rather it be part of the constructor (fail fast). The exception class is correct. Message should be something like "Invalid {name of param} value. Must be a positive integer.".

Finally, please remember to add tests. There should be a way to access those values. I thought about a package-private getter for the URLConnection (internally it just calls and returns url.openConnection()) but then you'd need to assert somehow that the getJWKS method is calling internally that getter.

[skjolber]

@lbalmaceda changed type to Integer, added validation in constructor and added unit tests.

[lbalmaceda]

LGTM

[skjolber]

Accidentally used tabs for indent, changed to spaces.

[lbalmaceda]

@skjolber thanks. I did notice the indentation was looking weird specially on the inner class, but thought you forgot to run the code formatter.