Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build public key once on Jwk #195

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LelvProgrammer
Copy link

Changes

This is just a silly change for creating the public key only once for a Jwk. This improvement lies in the fact that the Jwk is designed as an immutable class, but the method for getting the public key generates a new instance all the time out of values that never change. Therefore, it would be better to just store this information once it's built and not have to regenerate it every time it's asked for - which happens often when one considers that Jwk objects tend to be cached.

Testing

No new test was added, as no functionality was added nor has any contract changed - a new private attribute was added for storing some information.

Checklist

@LelvProgrammer LelvProgrammer requested a review from a team as a code owner September 3, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant