Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change AuthParams to an interface in Email and SMS Connection + Changelog for v0.7.0 #75

Merged
merged 2 commits into from
Jun 22, 2022
Merged

Change AuthParams to an interface in Email and SMS Connection + Changelog for v0.7.0 #75

merged 2 commits into from
Jun 22, 2022

Conversation

sergiught
Copy link
Contributor

Description

Change AuthParams to an interface in Email and SMS Connection due to the API at times returning a string and other times map[string]interface{}.

Also adds changelog for v0.7.0.

References

Testing

  • This change adds test coverage for new/changed/fixed functionality

Checklist

  • I have read and agreed to the terms within the Auth0 Code of Conduct.
  • I have read the Auth0 General Contribution Guidelines.
  • I have reviewed my own code beforehand.
  • I have added documentation for new/changed functionality in this PR.
  • All active GitHub checks for tests, formatting, and security are passing.
  • The correct base branch is being used, if not main.

@sergiught sergiught self-assigned this Jun 22, 2022
@sergiught sergiught force-pushed the patch/auth-params-update branch from b3e9a25 to de5dd88 Compare June 22, 2022 16:28
@sergiught sergiught marked this pull request as ready for review June 22, 2022 16:29
@sergiught sergiught requested a review from a team as a code owner June 22, 2022 16:29
@sergiught sergiught merged commit 161308b into main Jun 22, 2022
@sergiught sergiught deleted the patch/auth-params-update branch June 22, 2022 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willvedd willvedd willvedd approved these changes

Assignees

@sergiught sergiught

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergiught @willvedd