-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Organizations for Client Credentials #432
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duedares-rvj
force-pushed
the
SDK-4915/client-credentials
branch
from
August 16, 2024 07:44
88e6be3
to
9cf2217
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
=======================================
Coverage 95.64% 95.65%
=======================================
Files 49 49
Lines 8158 8172 +14
=======================================
+ Hits 7803 7817 +14
Misses 238 238
Partials 117 117 ☔ View full report in Codecov by Sentry. |
duedares-rvj
changed the title
Organizations for Client Credentials
Add Organizations for Client Credentials
Aug 20, 2024
acwest
previously approved these changes
Aug 20, 2024
acwest
previously approved these changes
Aug 21, 2024
developerkunal
requested changes
Aug 22, 2024
developerkunal
temporarily deployed
to
internal
August 26, 2024 15:18 — with
GitHub Actions
Inactive
developerkunal
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
default_organization
to GET/PATCH endpoints/api/v2/clients/{id}
default_organization
to POST endpoints/api/v2/clients/
q
for GET/api/v2/clients
identifiers
for GET/api/v2/organizations/{org_id}/client-grants
grant_ids
for GET/api/v2/resource-servers
📚 References
Required changes have been made in line with the documentation here
Management API docs here
🔬 Testing
Relevant test cases and their recordings have been added to ensure changes as described above.
All created resources are cleaned up after the assertions are completed.
make test FILTER=TestOrganizationManager_ClientGrantsWithOrg
📝 Checklist