Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add is_signup_enabled field to OrganizationConnection #413

Conversation

developerkunal
Copy link
Contributor

🔧 Changes

  • Add is_signup_enabled field to OrganizationConnection

📚 References

🔬 Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@developerkunal developerkunal requested a review from a team as a code owner June 7, 2024 10:31
Copy link

@ubenzer ubenzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've only taken a visual look to management/organization.go and management/organization_test.go and it LGTM.

Please note that we should coordinate when the SDK changes are released. (PMs to decide) It could be confusing to have the SDK released before the feature release.

@developerkunal developerkunal merged commit 7221b14 into main Jun 10, 2024
7 checks passed
@developerkunal developerkunal deleted the SDK-4848-add-to-support-Signing-up-with-Organization-Membership branch June 10, 2024 09:14
@developerkunal developerkunal mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants