-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeviceCredentialsManager
to manage device credentials
#369
Add DeviceCredentialsManager
to manage device credentials
#369
Conversation
d909447
to
1c931a5
Compare
1c931a5
to
8ab22cb
Compare
8ab22cb
to
ad40d7b
Compare
ad40d7b
to
b7908f0
Compare
@ewanharris Hi. Any chance you could review this when you have time? |
b7908f0
to
031e4c4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 95.81% 95.34% -0.47%
==========================================
Files 51 52 +1
Lines 8461 10339 +1878
==========================================
+ Hits 8107 9858 +1751
- Misses 236 363 +127
Partials 118 118 ☔ View full report in Codecov by Sentry. |
Hey @Zarux , I hope you're doing well. As I was going through the PR, I wanted to share some thoughts with you. I've noticed a few areas where we could potentially improve, particularly in the test cases. Using getters throughout the codebase can offer some significant benefits, especially in GoLang. Additionally, incorporating random functions into our test details could greatly enhance the robustness of our testing framework. This approach ensures that even when we're dealing with multiple test cases, like creating or deleting tests, we're less likely to encounter errors along the way. If you'd like, you can check out this link for a reference: https://github.com/auth0/go-auth0/blob/main/management/connection_test.go Let me know if you have any questions or need further clarification! |
hi @Zarux @developerkunal - I'd like to see this feature get merged in. Is it being worked? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @Zarux and @JohnRoesler, @Zarux, as per our branch restrictions, we are unable to merge the PR until the commits are signed. Could you please sign the commits so we can proceed with the merge? |
e5d61bb
to
f48f4fe
Compare
DeviceCredentialsManager
to manage device credentials
thanks @developerkunal 👏 |
The management API is currently lacking support for the device-credentials endpoints. This PR adds the availabe methods for that endpoint.
https://auth0.com/docs/api/management/v2/device-credentials/get-device-credentials
🔧 Changes
Added support for Device Credentials in the management API with the methods:
DeviceCredentials.Create
DeviceCredentials.List
DeviceCredentials.Delete
🔬 Testing
All new methods added have corresponding tests
📝 Checklist