[SDK-3627] Make buildLogoutUrl internal only and replace with onRedirect handler on logout #982
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Similar to #948/#980 this removes
buildLogoutUrl
from the public API making it an internal private API, and instead adds a similaronRedirect
handler that will perform the redirection, continuing to usewindow.location.assign
if not provided. This change has the consequence that thelogout
method is no longer synchronous and must always be await-edFor those that used
buildLogoutUrl
the change looks as followsIf you were previously using
localOnly
, this should be replaced with a handler that does nothing, like so:Internally, this also removes the
clearSync
function on CacheManager as given that thelogout
now always returns a Promise we no longer need to switch to a synchronous method to remove the keys and prevent race conditionsChecklist