[SDK-3586] Do not fallback to refreshing tokens via iframe method by default #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
requested changes
Aug 14, 2022
ewanharris
force-pushed
the
feat/SDK-3586
branch
from
bcec2f9
to
9e62367
Compare
frederikprijck
approved these changes
Aug 16, 2022
frederikprijck
changed the title
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Updates the
useRefreshTokensFallbackproperty to now default to false, so the library will no longer fallback to the iframe method by default when refreshing a token fails.Updates any tests where required (all tests that can have opposite cases do) and adds a toggle to the playground for this setting so that the integration tests continue to function.
Checklist