Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle NPE when no popup is available #888

Merged
merged 2 commits into from
Mar 25, 2022
Merged

fix: handle NPE when no popup is available #888

merged 2 commits into from
Mar 25, 2022

Conversation

stevehobbsdev
Copy link
Contributor

Changes

This PR handles the event where no popup window is available so that it throws a custom error, instead of falling through and eventually failing with a null reference exception.

Fixes #886

Testing

  • This change adds unit test coverage
  • This change adds integration test coverage
  • This change has been tested on the latest version of the platform/language

Checklist

@stevehobbsdev stevehobbsdev added CH: Fixed PR is fixing a bug review:tiny Tiny review labels Mar 24, 2022
@stevehobbsdev stevehobbsdev marked this pull request as ready for review March 24, 2022 14:07
@stevehobbsdev stevehobbsdev requested a review from a team as a code owner March 24, 2022 14:07
@stevehobbsdev stevehobbsdev merged commit 682591f into master Mar 25, 2022
@stevehobbsdev stevehobbsdev deleted the fix/null-popup branch March 25, 2022 12:23
@stevehobbsdev stevehobbsdev mentioned this pull request Apr 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederikprijck frederikprijck frederikprijck approved these changes

Assignees
No one assigned
Labels
CH: Fixed PR is fixing a bug review:tiny Tiny review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NPE if browser blocks popups could be handed more gracefully
2 participants
@stevehobbsdev @frederikprijck