Make RedirectLoginOptions and RedirectLoginResult accept generic AppState #846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederikprijck
added
CH: Changed
adamjmcgrath
approved these changes
Nov 30, 2021
|
Looks good, we'll likely want to reflect this change in |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This SDK uses an
appStateproperty on bothRedirectLoginOptionsandRedirectLoginResult, allowing consumers to put object ofanytype as the appState on login, and get the values back from the transaction.This PR adds a generic parameter to both
RedirectLoginOptionsandRedirectLoginResultso that consumers can specify the type for theappStatethey are using.For example, the angular sdk uses
{ target: string }(https://github.com/auth0/auth0-angular/blob/master/projects/auth0-angular/src/lib/auth.service.ts#L305) for the appState to restore the previous route after redirecting, however the users have no type hinting and have no idea thatappStateaccepts atargetproperty becauseappStateis of type any.