Prevent nowProvider from being passed to authorize endpoint #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehobbsdev
commented
Nov 16, 2021
Comment on lines
-36
to
-43
| const assertUrlEquals = (actualUrl, host, path, queryParams) => { | ||
| const url = new URL(actualUrl); | ||
| expect(url.host).toEqual(host); | ||
| expect(url.pathname).toEqual(path); | ||
| for (let [key, value] of Object.entries(queryParams)) { | ||
| expect(url.searchParams.get(key)).toEqual(value); | ||
| } | ||
| }; |
There was a problem hiding this comment.
This was duplicated from the one in helpers.ts, so I removed it.
stevehobbsdev
commented
Nov 16, 2021
Comment on lines
+4
to
+5
| "noImplicitAny": false, | ||
| "target": "es6" |
There was a problem hiding this comment.
es6 for testing so that I can get access to URLSearchParams.entries(), shouldn't cause any problems with the SDK at runtime?
|
Regarding coverage, I've looked at it locally and the level of coverage hasn't changed from |
adamjmcgrath
approved these changes
Nov 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR prevents
nowProviderfrom being passed through the URL when logging in. The fundamental change is thatnowProvideris added to the destructure list inAuth0Client._getParams.In addition, I've attemped to help prevent this in the future by adding a test that includes all the client options and verifying they're not in the URL. Adding this test flagged up a couple other properties that should have been excluded, so these have also been added.
Also did some refactoring in
_getParamsto tidy up the code a bit.References
Fixes #836
Testing
Checklist