Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix popup blocker showing for loginWithPopup in Firefox & Safari #732

Merged
merged 4 commits into from
Apr 12, 2021
Merged

Fix popup blocker showing for loginWithPopup in Firefox & Safari #732

merged 4 commits into from
Apr 12, 2021

Commits on Apr 9, 2021

  1. Move popup opening outside an async context

    Steve Hobbs committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    eb2ec25 View commit details
    Browse the repository at this point in the history

  2. Make loginWithPopup params optional instead of using defaults

    Steve Hobbs committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    ee31116 View commit details
    Browse the repository at this point in the history

  3. Fix tests

    Steve Hobbs committed Apr 9, 2021
    Configuration menu
    Copy the full SHA
    8c86991 View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2021

  1. Merge branch 'master' into fix/firefox-popup

    @frederikprijck
    frederikprijck authored Apr 12, 2021
    Configuration menu
    Copy the full SHA
    df62bae View commit details
    Browse the repository at this point in the history