Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated minor syntax, to allow for TypeScript compiler to be happier #714

Merged
merged 5 commits into from
Mar 8, 2021
Merged

Updated minor syntax, to allow for TypeScript compiler to be happier #714

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
587c6b5
fixed references, for correct syntax in typings
kachihro Mar 3, 2021
7728276
fixed references, for correct syntax in typings
kachihro Mar 3, 2021
edb7390
fixed description in comments
kachihro Mar 3, 2021
7325c58
removed unused ref, added distinct return type
kachihro Mar 3, 2021
b8cde8e
Merge branch 'master' into master
Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Auth0Client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ import {
RedirectLoginResult,
GetTokenSilentlyOptions,
GetTokenWithPopupOptions,
IdToken,
kachihro marked this conversation as resolved.
Show resolved Hide resolved
LogoutOptions,
RefreshTokenOptions,
OAuthTokenOptions,
Expand Down Expand Up @@ -419,10 +420,10 @@ export default class Auth0Client {
* (the SDK stores a corresponding ID Token with every Access Token, and uses the
* scope and audience to look up the ID Token)
*
* @typeparam TUser The type to return, has to extend {@link User}. Defaults to {@link User} when omitted.
* @typeparam TUser The type to return, has to extend {@link User}.
* @param options
*/
public async getUser<TUser extends User = User>(
public async getUser<TUser extends User>(
options: GetUserOptions = {}
): Promise<TUser | undefined> {
const audience = options.audience || this.options.audience || 'default';
Expand Down Expand Up @@ -827,8 +828,8 @@ export default class Auth0Client {
nonceIn,
code_challenge,
options.redirect_uri ||
this.options.redirect_uri ||
window.location.origin
this.options.redirect_uri ||
window.location.origin
);

const url = this._authorizeUrl({
Expand Down